Add ci.pipeline.display_name tag for Buildkite pipelines - #12079
Conversation
ci.pipeline.name currently carries the Buildkite pipeline slug, not the real pipeline name, but it can't be changed without breaking backend fingerprinting that keys off its current value. This adds a new, additive tag sourced from BUILDKITE_PIPELINE_NAME so the real pipeline name is available without touching existing behavior. Also renames BuildkiteInfo.BUILDKITE_PIPELINE_NAME to BUILDKITE_PIPELINE_SLUG_ENV_VAR since it actually holds the BUILDKITE_PIPELINE_SLUG env var name, which was misleading now that a real pipeline-name-backed constant exists alongside it.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
![datadog-datadog-us1-prod[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The Buildkite path keeps the existing slug-backed ci.pipeline.name and conditionally adds ci.pipeline.display_name from BUILDKITE_PIPELINE_NAME; when that variable is absent, the shared null-filtering logic omits only the new tag. No diff-only behavioral regression was identified, although the Gradle test could not run because the wrapper distribution was unavailable offline.
🤖 Datadog Autotest · Commit 89a16cd · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
daniel-mohedano
added
type: feature
daniel-mohedano
left a comment
daniel-mohedano
left a comment
There was a problem hiding this comment.
left a small nit, but LGTM, thanks for the contribution! 🚀
…civisibility/ci/BuildkiteInfo.java Co-authored-by: Daniel Mohedano <daniel.mohedano@datadoghq.com>
…civisibility/ci/BuildkiteInfo.java Co-authored-by: Daniel Mohedano <daniel.mohedano@datadoghq.com>
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7e074d7 | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
gbrandrea
changed the title
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status in_progress |
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status in_progress |
409bc13
into
master
PerfectSlayer
changed the title
2 participants
What
Adds a new, additive
ci.pipeline.display_nametag for Buildkite, sourced fromBUILDKITE_PIPELINE_NAME(the real pipeline name), alongside the existingci.pipeline.nametag.Why
ci.pipeline.namecurrently carries the Buildkite pipeline slug (BUILDKITE_PIPELINE_SLUG), not the real pipeline name. We can't changeci.pipeline.name's value without a breaking change, since the backend computes pipeline fingerprinting from it today. This PR adds the real name as a new, separate tag instead. A future major-version release will eventually swapci.pipeline.nameover to the real name and retire this tag — that's out of scope here.Scope is intentionally limited to Buildkite only; no other CI provider is touched, and
ci.pipeline.name's source is untouched.test-environment-trigger: skip