Add CI, apply drupal-extension-scaffold, and fix code style - #8
Merged
Conversation
…alCI Applies the drupal_extension_scaffold (v4.17.0) for standardized local development and CI tooling, on top of Julian Pustkuchen's .gitlab-ci.yml and Kieran Cott's DI refactor (MR !13), then makes the full pipeline (phpcs, phpstan, rector, eslint, cspell, phpunit) actually pass: - Remove legacy .circleci/ setup, replaced by .gitlab-ci.yml + .github/ - Resolve all PHPStan errors and add strict_types across the module - Fix D10/D11 cross-version PHPStan/Rector conflicts (drupalCreateUser() return-type narrowing needed on D10 but redundant on D11; skip the two Rector rules that would convert PHPUnit annotations to attributes, which D10's PHPUnit 10 doesn't support) - Remove DrevOps/PHPCompatibility/testVersion from phpcs.xml and exclude rector.php from phpstan.neon - sniffs/classes not available in DrupalCI's environment - Drop the phpstan.neon ignoreErrors path restriction that never matched DrupalCI's checkout-root scan context (paths report without the web/modules/custom/ prefix there, unlike the local build/ tree) - Exclude .devtools/ from phpcs (scaffold infrastructure, not module code) - Drop .eslintrc.json's airbnb-base extend and .prettierrc.json's @homer0/prettier-plugin-jsdoc plugin - both fail to resolve under DrupalCI's core-only node_modules; keep yml/prettier plugin support since DrupalCI also lints this module's own YAML files - Configure DrupalCI GitLab CI variables and add phpunit.gitlab-ci.xml - Add cloudflared dev-tunnel scripts, wire DRUSH_URI into drush/login, and wire the missing start-/stop- hook calls into .devtools/start and .devtools/stop so the tunnel scripts actually run (the scaffold's .devtools/provision already called its provision- hook; start/stop never called theirs) Confirmed all gitlab.local pipeline jobs pass (phpcs, phpstan, eslint, phpunit, cspell, composer-lint) on both Drupal 10 and Drupal 11.
Decipher
force-pushed
the
feature/3587949-add-gitlab-ci-and-fixes
branch
from
August 3, 2026 05:59
fd52303 to
8c5dc7d
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitlab-ci.ymlfor Drupal.org GitLab CI (Julian Pustkuchen, Kieran Cott - MR !13)drupal-extension-scaffoldv4.17.0 for standardized local dev/CI toolingstrict_typesthroughoutResolves https://www.drupal.org/project/jsonapi_views/issues/3587949
Test plan
DRUPAL_VERSION=10 make build && make lintpassesDRUPAL_VERSION=11 make build && make lintpasses