Repository navigation
[TRTLLM-16217][test] Add VR200 4-GPU serve perf cases for DeepSeek V4 Pro and Kimi K3 - #19260
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe QA configuration adds eleven VR200 4-GPU serving performance tests for DeepSeek V4 Pro Base FP8, DeepSeek V4 Pro FP4, and Kimi K3. The tests cover throughput, latency, interactive, and context-length workloads with model-specific settings and 120-second timeouts. ChangesVR200 performance tests
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change adds VR200 serving performance coverage for three models without altering production runtime behavior. It is mergeable, with hardware validation still appropriate as follow-up. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
… Pro and Kimi K3 Extend the shared B200/GB200/B300/GB300/VR200 4-GPU condition block (compute_capability 10.0-10.7) with DEP4/TEP4 serve-backend shapes for deepseek_v4_pro_base_fp8, deepseek_v4_pro_fp4, and kimi_k3, mirroring the ep:8-tp:8-gpus:8 B300 cases already in the 8-GPU-only condition block. Neither model has a 4-GPU config validated on B200/B300 (both are pinned to ep=tp=8 there; the Kimi K3 deployment guide states TEP8 is the minimum topology that fits GB300-class per-GPU memory), but VR200's larger per-GPU HBM makes the same DEP4/TEP4 shapes fit. Signed-off-by: Ruodi Lu <ruodil@users.noreply.github.com>
75540ae to
eb58957
Compare
|
/bot run |
|
PR_Github #74914 [ run ] triggered by Bot. Commit: |
|
PR_Github #74914 [ run ] completed with state |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Semantic conflict reviewThe verdict of record is the Latest recorded state: Possible semantic conflict for head Best-effort AI judgment for the recorded revisions. PASS, FAIL and INCONCLUSIVE may be incomplete or incorrect. PR authors and reviewers should independently verify the evidence and relevant behavior. This semantic review and its status/workflow are advisory, not required merge checks under current repository rules; other merge requirements still apply. Advisory status does not make a confirmed defect safe to ignore.
Processed request and reply comments are minimized to reduce timeline noise; they remain expandable for audit. |
Summary
Test plan
🤖 Generated with Claude Code
Dev Engineer Review
deepseek_v4_pro_base_fp8,deepseek_v4_pro_fp4, andkimi_k3.deepseek_v4_pro_fp4serve configuration patterns.QA Engineer Review
ep=4,tp=4, four GPUs, and 120-second timeouts.Per-File QA Perspective
tests/integration/test_lists/qa/llm_perf_core.yml: Adds manual-QA coverage for three models on VR200 4-GPU configurations. Verify model loading, workload selection, throughput, latency, and timeout behavior.tests/integration/defs/perf/pytorch_model_config.py: Adds serve configuration patterns fordeepseek_v4_pro_fp4. Verify the selected MoE backend, KV-cache dtype, attention-DP behavior, and MTP settings.