4.x: Disposable no longer impls AutoCloseable - #8184
Merged
akarnokd merged 2 commits intoJun 26, 2026
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.558 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8184 +/- ##
============================================
- Coverage 98.33% 98.32% -0.01%
- Complexity 6933 6935 +2
============================================
Files 785 785
Lines 48999 48998 -1
Branches 6599 6599
============================================
- Hits 48181 48176 -5
+ Misses 623 622 -1
- Partials 195 200 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.558 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making
DIsposabledirectlyAutoCloseableadds unnecessary resource warnings to most spaces.Disposableis mainly there to signal dispose/cancel, not specifically resource lifecycles.The interface no longer extends AutoCloseable, all places where
SuppressWarnings("resource")have been removed.A new method
Disposable.asAutoCloseablewas added for the case when a try-with-resources is needed over it.