🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

Storybook e2e: add small, compact and icon examples to button matrix - #80793

Merged
simison merged 4 commits into
trunkfrom
update/component-story-e2e-sizes
Jul 29, 2026
Merged

Storybook e2e: add small, compact and icon examples to button matrix#80793
simison merged 4 commits into
trunkfrom
update/component-story-e2e-sizes

Conversation

@simison

@simison simison commented Jul 28, 2026

Copy link
Copy Markdown
Member

What?

Expands button matrix with "small", "compact" and "with icon" examples.

Also center-aligns buttons in row so that it's easier to compare now that they're different sizes.

Why?

While working on #79993, I've found manually adding these anyway to observe changes so might as well add here.

How?

Testing Instructions

Run npm run storybook:e2e:dev

Testing Instructions for Keyboard

Screenshots or screencast

UI Button

Screenshot 2026-07-28 at 17 24 43

Components Button

Screenshot 2026-07-28 at 17 24 51

Use of AI Tools

yes

@simison simison added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Storybook Storybook and its stories for components labels Jul 28, 2026
@github-actions github-actions Bot added [Package] Components /packages/components [Package] UI /packages/ui labels Jul 28, 2026
@simison
simison marked this pull request as ready for review July 28, 2026 14:30
@simison
simison requested review from a team and ajitbohra as code owners July 28, 2026 14:30
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: simison <simison@git.wordpress.org>
Co-authored-by: aduth <aduth@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@simison
simison force-pushed the update/component-story-e2e-sizes branch from 61dead3 to 8547ab8 Compare July 28, 2026 14:31
@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 7.75 MB

compressed-size-action

@simison
simison force-pushed the update/component-story-e2e-sizes branch from 8547ab8 to 2470cd2 Compare July 28, 2026 16:31
@github-actions

Copy link
Copy Markdown

Flaky tests detected in 2470cd2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/30378654158
📝 Reported issues:

@aduth aduth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

That "with icon" example for @wordpress/ui Button looks like it could use some improvement 😬

@simison

simison commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

That "with icon" example for @wordpress/ui Button looks like it could use some improvement 😬

Do you mean the unstyled one? I thought the same, but then it's truly just very unstyled. 😅

image

@simison
simison merged commit e23d62f into trunk Jul 29, 2026
60 checks passed
@simison
simison deleted the update/component-story-e2e-sizes branch July 29, 2026 11:26
@github-actions github-actions Bot added this to the Gutenberg 23.8 milestone Jul 29, 2026
@aduth

aduth commented Jul 29, 2026

Copy link
Copy Markdown
Member

That "with icon" example for @wordpress/ui Button looks like it could use some improvement 😬

Do you mean the unstyled one? I thought the same, but then it's truly just very unstyled. 😅

Yeah that's the one I meant, forgot to specify 🤦 Interesting point about "unstyled", and just how unstyled we're happy for it to be. I guess it may be fine as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Package] UI /packages/ui Storybook Storybook and its stories for components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants