🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

Don’t show traceback on 'breeze tests' subprocess returning non-zero #23868

Closed

Description

@uranusjr

Body

Currently, if any tests fail when breeze tests is run, Breeze 2 would emit a traceback pointing to the docker-compose subprocess call. This is due to Docker propagating the exit call of the underlying pytest subprocess. While it is technically correct to emit an exception, the traceback is useless in this context, and only clutters output. It may be a good idea to add a special case for this and suppress the exception.

A similar situation can be observed with breeze shell if you run exit 1 in the shell.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.

Activity

  1. added a commit that references this issue on May 24, 2022
    78b6bc4
  2. potiuk commented on May 24, 2022

    @potiuk
    Member

    Yep. Most of the commands had it already. Also I tihnk shell has it already (but maybe there is another case):

    Screenshot 2022-05-24 at 17 44 35

  3. potiuk commented on May 24, 2022

    @potiuk
    Member

    Fix in #23897

  4. added a commit that references this issue on May 24, 2022
    d788f4b
  5. added a commit that references this issue on May 27, 2022
    99d62a7
  6. added a commit that references this issue on Jun 2, 2022
    b10afd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions