Disable tests failing on Windows - #3185
Conversation
* The conversion shell scripts cannot be executed on Windows. * Path related tests trying to create symbolic links fail with an exception on Windows, as documented in java.nio.file.Files.createSymbolicLink(Path, Path, FileAttribute<?>...)
scordio
added
the
status: pending investigation
301ca01 to
c730d18
Compare
|
Hi @Bananeweizen, apologies for getting back so late to this PR!
You're totally right and I wonder why our build doesn't fail on the Windows runner – I'll dig a bit and get back to you.
I couldn't find a specific reference to Windows at As these tests can be successfully executed on the GitHub runner (and I suppose in any other Windows environment with the appropriate permissions), it might be a good idea to introduce a custom JUnit condition to address this constellation. I will take care of that on top of your changes. |
I refactored how we do script testing in #3785: this is now a separate Maven module running on non-Windows platforms only, and using JUnit Although my PR has taken a different direction from this one, I truly appreciated that you looked into the problem, somehow hidden before, therefore I'm adding you as a coauthor 😉 |
scordio
removed
the
status: pending investigation
2 participants
java.nio.file.Files.createSymbolicLink(Path, Path, FileAttribute<?>...)
Check List:
With this change I can build the complete Maven reactor. Without it, there are around 50 test failures, exactly on the disabled test classes and methods.