🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

Use coverage to filter out mutations - #438

Merged
Otto-AA merged 16 commits into
boxed:mainfrom
loufranco:loufranco/395-use-coverage-to-filter-out-mutations
Sep 13, 2025
Merged

Use coverage to filter out mutations#438
Otto-AA merged 16 commits into
boxed:mainfrom
loufranco:loufranco/395-use-coverage-to-filter-out-mutations

Conversation

@loufranco

@loufranco loufranco commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Closes #395

  1. Added a config called mutate_only_covered_lines so that the default behavior is NOT to use coverage
  2. I needed to reorder the copy_also and source folder setup to happen before coverage
  3. tests and e2e tests added

This works on my project and in the e2e one.

@loufranco
coverage added to requirements (will be used by mutmut run)
aa7a953
@loufranco
mutate_only_covered_lines added to config to control whether coverage…
dab1a28 
….py is used to filter down mutations
@loufranco
code_coverage.py added to run tests under coverage.py and get the cov…
47282f5 
…ered lines
@loufranco
setup_source_paths refactored out of _run (moving later)
3a5ed7b
@loufranco
store_lines_covered_by_tests added to gather the covered lines
73530f8 
We need to move up some other calls (copy_also_copy_files() and setup_source_paths()) so that their effects are in place when we do code coverage
@loufranco
Pass the covered_lines set to the the file mutator and use it in _sho…
ee7b564 
…uld_mutate_node
@loufranco
test that mutants are not generated for uncovered lines
7eec1cd
@loufranco
e2e test for when mutate_only_covered_lines = true
11c59d1
@loufranco loufranco mentioned this pull request Sep 11, 2025
Closed
Otto-AA
Otto-AA reviewed Sep 12, 2025
View reviewed changes

@Otto-AA Otto-AA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

I skimmed through the diff and it looks good so far, only minor comments. I likely have time to test it out on the weekend.

Comment thread e2e_projects/mutate_only_covered_lines/src/mutate_only_covered_lines/__init__.py
Comment thread mutmut/__main__.py
Otto-AA
Otto-AA reviewed Sep 12, 2025
View reviewed changes
Comment thread e2e_projects/mutate_only_covered_lines/pyproject.toml
Otto-AA
Otto-AA reviewed Sep 12, 2025
View reviewed changes
Comment thread mutmut/file_mutation.py Outdated
@loufranco
mutate_only_covered_lines e2e test added to test multiline
74ac2e8 
I inspected the file generated in mutants and the "Bar" on line 10 is not mutated, but coverage.py reported that it wasn't covered, so the bug is in coverage.py.
@loufranco
mutate_only_covered_lines_multiline added to README
4614bcb
@loufranco
Union used instead of pipe to support Python 3.9
05971a9
@loufranco
e2e tests added for more options (including pragma)
f42d9fc
Otto-AA
Otto-AA reviewed Sep 13, 2025
View reviewed changes
Comment thread README.rst Outdated
Otto-AA
Otto-AA reviewed Sep 13, 2025
View reviewed changes
Comment thread README.rst Outdated
@Otto-AA
Otto-AA merged commit 2acbf1f into boxed:main Sep 13, 2025
5 checks passed
@Otto-AA

Otto-AA commented Sep 13, 2025

Copy link
Copy Markdown
Collaborator

Looks very good. While testing, I've found two bugs, but they were not related to this PR 🙃

I've added some more E2E tests, and a minor performance change (only calling cov.get_data() once for all files).

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Otto-AA Otto-AA Otto-AA left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Non-tested statements can be reported as "survived" (🙁) instead of "no tests" (🫥)

2 participants

@loufranco @Otto-AA