fix(coderd): enforce required external auth on workspace create - #26314
Merged
dylanhuff-at-coder merged 1 commit intoJun 25, 2026
Conversation
Required external auth was only enforced by client-side preflight checks in the CLI and UI, so creating a workspace directly through the REST API succeeded even when the owner had not authenticated with a required provider. The build then ran with an empty token and produced a broken workspace. Workspace creation now validates the workspace owner's external auth links against the template version's non-optional providers before any workspace row is inserted or prebuilt workspace is claimed, returning 403 with one validation entry per missing provider. The owner is the subject of the check, not the initiator, because build-time token injection uses the owner's links.
dylanhuff-at-coder
marked this pull request as ready for review
June 23, 2026 16:26
aslilac
approved these changes
Jun 25, 2026
| err := json.Unmarshal(templateVersion.ExternalAuthProviders, &rawProviders) | ||
| if err != nil { | ||
| httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{ | ||
| return nil, httperror.NewResponseError(http.StatusInternalServerError, codersdk.Response{ |
Contributor
Author
There was a problem hiding this comment.
Not new — httperror.NewResponseError/WriteResponseError have been around since #18719. I just pulled this out into templateVersionExternalAuthForUser so it returns the error instead of writing inline, which lets requireWorkspaceOwnerExternalAuth reuse it :)
dylanhuff-at-coder
deleted the
dylan/plat-241-api-workspace-creation-bypasses-required-external-auth
branch
June 25, 2026 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required external auth (
optional = false) was only enforced by client-side preflight checks, so creating a workspace via the REST API succeeded even when the owner had never authenticated, producing a broken workspace.createWorkspacenow validates the workspace owner's external auth server-side and returns 403 before any row is inserted or prebuild is claimed. The owner (not the initiator) is checked because build-time token injection uses their links, so this also covers admin-on-behalf-of creates and prebuild claims. Useoptional = trueto allow pre-provisioning for unauthenticated users.Fixes PLAT-241.