🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

fix: upgrade nixpkgs to 25.05 and pin protoc 23.4 - #26584

Merged
geokat merged 1 commit into
mainfrom
george/upgrade-nixpkgs-to-2505
Jun 23, 2026
Merged

fix: upgrade nixpkgs to 25.05 and pin protoc 23.4#26584
geokat merged 1 commit into
mainfrom
george/upgrade-nixpkgs-to-2505

Conversation

@geokat

@geokat geokat commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

nix develop and nix-shell were broken because the nixos-24.11 google-chrome derivation still pointed at Chrome 138, and Google no longer serves that versioned .deb:

$ nix-shell
these 2 derivations will be built:
  /nix/store/af59wjk8a8ys18bam92y3jns14pgj01n-google-chrome-stable_138.0.7204.49-1_amd64.deb.drv
  /nix/store/bc5fw07dw1f7g7y3yv7fricbynsnfx21-google-chrome-138.0.7204.49.drv
building '/nix/store/af59wjk8a8ys18bam92y3jns14pgj01n-google-chrome-stable_138.0.7204.49-1_amd64.deb.drv'...

trying https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_138.0.7204.49-1_amd64.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download google-chrome-stable_138.0.7204.49-1_amd64.deb from any mirror
error: builder for '/nix/store/af59wjk8a8ys18bam92y3jns14pgj01n-google-chrome-stable_138.0.7204.49-1_amd64.deb.drv' failed with exit code 1;
       last 7 log lines:
       >
       > trying https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_138.0.7204.49-1_amd64.deb
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download google-chrome-stable_138.0.7204.49-1_amd64.deb from any mirror
       For full logs, run 'nix-store -l /nix/store/af59wjk8a8ys18bam92y3jns14pgj01n-google-chrome-stable_138.0.7204.49-1_amd64.deb.drv'.
error: 1 dependencies of derivation '/nix/store/bc5fw07dw1f7g7y3yv7fricbynsnfx21-google-chrome-138.0.7204.49.drv' failed to build

This PR updates the flake's main nixpkgs input to nixos-25.05 so the shell resolves a current Chrome package again.

The 25.05 upgrade also removed the protobuf_23 attr. Rather than switching the shell to the channel-default protobuf package, pin protoc 23.4 explicitly from the upstream protobuf release archives. This keeps the local Nix shell aligned with mise.toml and the CI/release codegen toolchain.

Disclaimer: I'm not experienced with Nix, so I used an agent to write most of the fix. I checked the download URLs and ran make pre-commit, make pre-push and scripts/develop.sh locally (Ubuntu 24.04.4 LTS).

@datadog-coder

datadog-coder Bot commented Jun 22, 2026 •
edited by datadog-coder-official Bot
Loading

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 1 Pipeline job failed

contrib | title   View in Datadog   GitHub Actions

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 21b8223 | Docs | Give us feedback!

@geokat geokat changed the title fix(flake.nix): upgrade nixpkgs to 25.05 and pin protoc 23.4 fix: upgrade nixpkgs to 25.05 and pin protoc 23.4 Jun 22, 2026
@geokat
geokat marked this pull request as ready for review June 22, 2026 20:51
@geokat
geokat requested a review from johnstcn June 22, 2026 20:51
johnstcn
johnstcn approved these changes Jun 23, 2026
View reviewed changes

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also be 100% ok if you decided you delete our nix config entirely, just sayin'

@geokat
geokat merged commit fccb238 into main Jun 23, 2026
61 of 64 checks passed
@geokat
geokat deleted the george/upgrade-nixpkgs-to-2505 branch June 23, 2026 16:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@geokat geokat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geokat @johnstcn