🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

fix(site): set external auth provider polling status individually (#2… - #26604

Merged
f0ssel merged 1 commit into
release/2.33from
rowan/26313_2_33
Jun 27, 2026
Merged

fix(site): set external auth provider polling status individually (#2…#26604
f0ssel merged 1 commit into
release/2.33from
rowan/26313_2_33

Conversation

@rowansmithau

Copy link
Copy Markdown
Member

Cherry-pick of #26313

Original PR: #26313 — fix(site): set external auth provider polling status individually

…6313)

fixes #22420
ref DEVEX-369
ref DEVEX-269

The bug on `CreateWorkspacePage`, where clicking one external auth
provider login button disabled all providers' login buttons, was caused
by providers all sharing a single polling status (`"idle" | "polling" |
"abandoned"`) in the `useExternalAuth` hook.

## changes

- Instead of setting one status across all providers, the polling status
in `useExternalAuth` is now tracked for each provider in a record whose
keys are the providers' IDs.
- The biggest diff is a new Storybook file
CreateWorkspacePage.stories.tsx which reproduces the bug behavior from
the issue.
- Until now we've only had CreateWorkspacePageView.stories.tsx, which
isn't able to model the user interactions / API responses needed to
verify the bugfix. This file is unchanged.
- Also deletes `CreateWorkspacePage`'s `useExternalAuth` hook in favor
of the global `useExternalAuth` hook (see #26310)

(co-written with Coder Agents)
@rowansmithau
rowansmithau requested a review from f0ssel June 23, 2026 10:06
@rowansmithau rowansmithau self-assigned this Jun 23, 2026
@rowansmithau
rowansmithau marked this pull request as ready for review June 23, 2026 10:11
@rowansmithau
rowansmithau requested a review from matifali June 23, 2026 10:11
@f0ssel
f0ssel merged commit 4da9e0c into release/2.33 Jun 27, 2026
39 of 41 checks passed
@f0ssel
f0ssel deleted the rowan/26313_2_33 branch June 27, 2026 12:28
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants