🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

feat(site): limit dropdown module config fields to 50% width - #26682

Merged
aqandrew merged 8 commits into
mainfrom
aqandrew/devex-532-limit-dropdown-width-to-50-percent-grid-columns
Jun 25, 2026
Merged

feat(site): limit dropdown module config fields to 50% width#26682
aqandrew merged 8 commits into
mainfrom
aqandrew/devex-532-limit-dropdown-width-to-50-percent-grid-columns

Conversation

@aqandrew

Copy link
Copy Markdown
Contributor

closes DEVEX-532

other changes

just cleaning up typographic styles a bit to match Figma better

  • create TemplateBuilderTitle/TemplateBuilderSubtitle components for h2+p elements at the top of steps
  • left-align switch's description with its label

@aqandrew
aqandrew requested a review from jeremyruppel June 24, 2026 21:51
@linear-code

linear-code Bot commented Jun 24, 2026

Copy link
Copy Markdown

DEVEX-532

Comment thread site/src/pages/TemplateBuilder/TemplateBuilderHeader.tsx Outdated

@jeremyruppel jeremyruppel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one comment about the ComponentProps type, but this is great. approving ahead of the response because it's just a type comment

return (
<div className="flex flex-col gap-2">
// All fields span 2 columns, except for dropdowns which can only be 1 column (50% width)
<div className="!col-end-1 flex flex-col gap-2">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added this !important because I think when I visually verified the UI without it, I'd had grid-column-end: 1 set in DevTools 😅

I don't love using !important here, but imo it makes more sense than setting -col-end-1 on all other fields

Image

@aqandrew
aqandrew merged commit 973056d into main Jun 25, 2026
30 of 31 checks passed
@aqandrew
aqandrew deleted the aqandrew/devex-532-limit-dropdown-width-to-50-percent-grid-columns branch June 25, 2026 17:49
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants