feat: add network call badges to AI sessions table - #27341
Conversation
|
Review received here: |
662307d to
6517f5e
Compare
|
@EhabY Please see the new network columns section. |
SasSwart
changed the title
Documentation CheckUpdates Needed
Automated review via Coder Agents |
Surface the total and blocked Agent Firewall network calls on the AI sessions list. Sessions that did not pass through Agent Firewall show as "Disabled". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Apply frontend review feedback and Figma design refinements to the AI sessions network calls column: - Rename the column header to "Network Calls" and match sibling styling. - Fuse the total and blocked counts into a single two-segment panel, consistent with the In/Out Tokens column. - Color the blocked icon and count with the content-warning token. - Make both tooltips keyboard reachable (tabIndex plus sr-only label). - Remove the unused size prop and add keyboard interaction stories. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6517f5e to
600384b
Compare
…list Add the Network Calls column to the Sessions list column enumeration and explain the total/blocked counts and the No activity and Disabled states. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
EhabY
left a comment
EhabY
left a comment
There was a problem hiding this comment.
Two small follow ups for the tooltip behavior, but otherwise LGTM!
I think the table looks a bit crowded and could use a better design but I suppose that's out of scope for now.
| <TooltipTrigger asChild> | ||
| <span | ||
| tabIndex={0} | ||
| role="button" |
There was a problem hiding this comment.
This span has role="button" but there is no action behind it, it only opens a tooltip. ProvisionerVersion.tsx handles the same case with just tabIndex={0} and no role
Can we drop the role to match?
| <span className="inline-flex items-center gap-1 whitespace-nowrap text-content-secondary"> | ||
| Disabled | ||
| <span className="sr-only">More info</span> | ||
| <InfoIcon tabIndex={0} className="cursor-pointer size-icon-xs" /> |
There was a problem hiding this comment.
Only the inner svg is focusable, and it has no role or accessible name. Can we use HelpPopoverIconTrigger here instead, like AIBridgeHelpPopover does?
It's a real button with aria-label="More info", so keyboard and screen reader support come for free
…ility Make the network call tooltip trigger a real button and use the shared InfoTooltip for the disabled indicator, so both expose an accessible name and full keyboard support instead of a role-less focusable span and svg. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 participants
Surface the total and blocked Agent Firewall network calls on the AI sessions list. Sessions that did not pass through Agent Firewall show as "Disabled".