fix: redact env var values in agent debug manifest endpoint (#26904) - #27880
Merged
Conversation
Contributor
Documentation CheckUpdates Needed
Automated review via Coder Agents |
mtojek
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26904
Original PR: #26904 — fix: redact env var values in agent debug manifest endpoint
Merge commit: b33ff2d
Requested by: @jdomeracki-coder
Conflict resolution notes
The cherry-pick conflicted in
agent/agent.gobecause the newredactedManifestEnvValueconstant landed whererelease/2.34has theHandleHTTPDebugLogshandler. Resolved by keeping both: the existing handlerand the new constant. The manifest env-redaction block applied cleanly. The
./agent/...package builds successfully.Opened by Coder Agents on behalf of @jdomeracki-coder.