🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

fix!: require org membership for user ACLs (#26852) - #27884

Merged
jdomeracki-coder merged 2 commits into
release/2.34from
backport/26852-to-2.34
Aug 6, 2026
Merged

fix!: require org membership for user ACLs (#26852)#27884
jdomeracki-coder merged 2 commits into
release/2.34from
backport/26852-to-2.34

Conversation

@jdomeracki-coder

Copy link
Copy Markdown
Contributor

Backport of #26852

Original PR: #26852 — fix!: require org membership for user ACLs
Merge commit: 6b3341a
Requested by: @jdomeracki-coder

Clean cherry-pick, no conflicts.


Opened by Coder Agents on behalf of @jdomeracki-coder.

@jdomeracki-coder
jdomeracki-coder requested a review from Emyrk as a code owner August 5, 2026 10:26
@jdomeracki-coder jdomeracki-coder added the backport/v2.34 Backport PR targeting release/2.34 label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

👋 Hey @jdomeracki-coder!

This PR is targeting the release/2.34 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

@mtojek mtojek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR has been marked as introducing breaking changes, so we will introduce a breaking on into a patch release -> semver violations.

In principle we shouldn't do this, so can we confirm this is expected behavior?

@jdomeracki-coder

Copy link
Copy Markdown
Contributor Author

The original PR has been marked as introducing breaking changes, so we will introduce a breaking on into a patch release -> semver violations.

In principle we shouldn't do this, so can we confirm this is expected behavior?

Good callout, let's discuss on Slack

@jdomeracki-coder
jdomeracki-coder requested a review from mtojek August 6, 2026 08:14

@mtojek mtojek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed over slack and agreed to ship 👍

@jdomeracki-coder

Copy link
Copy Markdown
Contributor Author

As discussed internally, this patch is good to be backported to ESR

@jdomeracki-coder
jdomeracki-coder merged commit 85bcd5d into release/2.34 Aug 6, 2026
47 of 49 checks passed
@jdomeracki-coder
jdomeracki-coder deleted the backport/26852-to-2.34 branch August 6, 2026 12:45
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/v2.34 Backport PR targeting release/2.34

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants