🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

"Repository" link pulling from incorrect property in package.json  #235

Closed

Description

@jamsyoung

I am not sure when this behavior started. It def exists in node 5.6.0 with npm 3.7.5.

When doing "npm init" the default format for the "repository" url starts with git+

Example, edited for brevity. Showing only what is set by the "git repository" question.

$ npm init
git repository: https://github.com/cnnlabs/something.git
About to write to /Users/jyoung/dev/test/package.json:

{
  "repository": {
    "type": "git",
    "url": "git+https://github.com/cnnlabs/something.git"
  },
  "bugs": {
    "url": "https://github.com/cnnlabs/something/issues"
  },
  "homepage": "https://github.com/cnnlabs/something#readme"
}

ESDoc pulls the repository.url for the href of the "Repository" link, which is invalid since it starts with git+.

It would be more appropriate to pull the homepage property.

Activity

  1. jamsyoung commented on Feb 29, 2016

    @jamsyoung
    Author

    Changing this to read from homepage will probably break more people than are currently broken using git+ urls with the repository property.

  2. h13i32maru commented on Mar 6, 2016

    @h13i32maru
    Member

    Thanks this issue.
    I released the v0.4.6 that fixes this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions