TypeError: Cannot read property 'split' of undefined #301

Activity

1. moroine commented on Jun 23, 2016

   

   moroine

   on Jun 23, 2016

   More actions

   Same issue on my side
2. damirka commented on Jun 23, 2016

   

   damirka

   on Jun 23, 2016

   Last edited by damirka

   Author

   More actions

   To @moroine:

   I've found a way to fix this but it's completely incorrect and weird. Just added this condition:

   // in /usr/lib/node_modules/esdoc/out/Publisher/Builder/DocBuilder#1288
   if (prop.name === undefined) {
       return ice;
   }

   If you need a quick fix to generate docs - this can work. But I don't recommend to do it in any other case.

   UPD: There's an ice.loop('property', properties, function (i, prop, ice) { ... }) block and in some cases (I didn't go further) prop can be an empty object or smth. So the name property is undefined.

   It's funny that I've been migrating from JSDoc and after I removed some JSDoc tags (as I see now) it began to work properly even without this fix. 🎱
3. make-github-pseudonymous-again commented on Nov 2, 2016

   

   make-github-pseudonymous-again

   on Nov 2, 2016

   Last edited by make-github-pseudonymous-again

   More actions

   Here's an example that throws a similar error

   export class Product {
   
       constructor ( a , b ) {
           this.a = a ;
           this.b = b ;
       }
   
       zero ( ) {
           return [ this.a.zero( ) , this.b.zero( ) ] ;
       }
   
       plus ( [ a , b ] , [ A , B ] ) {
           return [ this.a.plus( a , A ) , this.b.plus( b , B ) ] ;
       }
   
   }

   Commenting out the plus method or adding

       /**
        * @param first
        * @param second
        */

   just before the plus method makes esdoc work again.
4. damirka commented on Nov 2, 2016

   

   damirka

   on Nov 2, 2016

   Last edited by damirka

   Author

   More actions

   Seems to me it's somehow related to destructive assignment and it's parsing. Did you try any other ways?

   // like this one
   function example({ a: A, b: B }, c = null, [ d = null ]) {
     // check params inside
   }
5. make-github-pseudonymous-again commented on Nov 2, 2016

   

   make-github-pseudonymous-again

   on Nov 2, 2016

   More actions

   No but I think your guess is correct.
6. h13i32maru commented on Dec 27, 2016

   

   h13i32maru

   on Dec 27, 2016

   Member

   More actions

   Thanks for this report.

   I will fix this bug in next version.
7. h13i32maru

   added

   Result: Accept

   Scope: ES6

   Scope: Internal

   Type: Bug

   on Dec 27, 2016
8. h13i32maru

   added this to the next-version milestone on Dec 27, 2016
9. h13i32maru commented on Dec 27, 2016

   

   h13i32maru

   on Dec 27, 2016

   Member

   More actions

   I fixed this bug.
   c8ae3f5

   And will release in next version.

   🎉React with 🎉1Reacted by Notas Hellout
10. h13i32maru

    closed this as completedon Dec 27, 2016