🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

Add ARM64 support for Windows - #73

Open
Harishmcw wants to merge 1 commit into
google:mainfrom
Harishmcw:win_arm64
Open

Add ARM64 support for Windows#73
Harishmcw wants to merge 1 commit into
google:mainfrom
Harishmcw:win_arm64

Conversation

@Harishmcw

@Harishmcw Harishmcw commented Mar 25, 2026

Copy link
Copy Markdown

This PR adds CI and MSVC ARM64 support for the crc32c library.

MSVC ARM64 builds were missing intrinsic handling and had placeholder flags (/arch:NOTYET). This PR replaces those placeholders with proper MSVC ARM64 implementation and adds a windows-11-arm CI runner to validate it.

Changes:

  • CI: Add windows-11-arm to the OS matrix with MSVC-only builds, pass -A ARM64 to CMake for ARM64 target generation
  • CMakeLists.txt: Replace /arch:NOTYET placeholder with proper MSVC ARM64 intrinsic detection; skip /arch:armv8.0 flag when natively targeting ARM64
  • crc32c_arm64.cc: Add MSVC-compatible Arm64_Vmull_P64 wrapper using neon_pmull_64, replace poly64_t with uint64_t for MSVC compatibility
  • crc32c_arm64.h: Add MSVC/GCC-Clang header split for ARM intrinsics
  • crc32c_arm64_check.h: Add Windows ARM64 runtime capability check using IsProcessorFeaturePresent

@google-cla

google-cla Bot commented Mar 25, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mayankag-qti

mayankag-qti commented Mar 27, 2026

Copy link
Copy Markdown

@khmyznikov FYI

@khmyznikov khmyznikov mentioned this pull request Mar 27, 2026
Open
@khmyznikov

khmyznikov commented May 21, 2026

Copy link
Copy Markdown

@Harishmcw could you sign the CLA?

@Harishmcw

Harishmcw commented May 25, 2026

Copy link
Copy Markdown
Author

@Harishmcw could you sign the CLA?

Sure, I’ll complete the CLA shortly.

@Harishmcw

Harishmcw commented May 28, 2026

Copy link
Copy Markdown
Author

@googlebot rescan

@Harishmcw

Harishmcw commented May 28, 2026

Copy link
Copy Markdown
Author

Hi @MaciejEteruniversum,

I’ve completed the Google CLA process now, and the CLA check has passed successfully on the PR.

Could you please take look at the PR when you get a chance?

Thanks!

@xieofxie

This comment was marked as duplicate.

Sign in to view
@xieofxie xieofxie mentioned this pull request Oct 10, 2026
Open
1 task done
@xieofxie

xieofxie commented Oct 10, 2026

Copy link
Copy Markdown

Create an issue to track the works need to be done on the parent repo here googleapis/google-cloud-python#18624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@MaciejEteruniversum MaciejEteruniversum MaciejEteruniversum approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Harishmcw @mayankag-qti @khmyznikov @xieofxie @MaciejEteruniversum