This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Repository navigation
feat: add created/started/ended properties to RowIterator. - #2260
Merged
Merged
Conversation
product-auto-label
Bot
added
size: m
Genesis929
changed the title
tswast
reviewed
Aug 12, 2025
| """Datetime at which the job was created. | ||
|
|
||
| See: | ||
| https://cloud.google.com/bigquery/docs/reference/rest/v2/Job#JobStatistics.FIELDS.creation_time |
Contributor
There was a problem hiding this comment.
I don't think this is available on the Query response object, is it?
Contributor
There was a problem hiding this comment.
Please update the link to the correct object: http://cloud.google.com/bigquery/docs/reference/rest/v2/jobs/query#body.QueryResponse.FIELDS.creation_time
Contributor
Author
There was a problem hiding this comment.
Thanks! Didn't notice the difference. Updated.
tswast
reviewed
Aug 13, 2025
Genesis929
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
added
kokoro:run
yoshi-kokoro
removed
kokoro:run
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
tswast
reviewed
Aug 14, 2025
Comment on lines
+892
to
+894
| job_resource_done["statistics"]["query"]["creationTime"] = str(1437767599006) | ||
| job_resource_done["statistics"]["query"]["startTime"] = str(1437767600007) | ||
| job_resource_done["statistics"]["query"]["endTime"] = str(1437767601008) |
Contributor
There was a problem hiding this comment.
To make the assertions easier, use datetime objects and a helper function like I added in #2250
def _to_millis(dt: datetime.datetime) -> str:
return str(
int(
(dt - datetime.datetime(1970, 1, 1, 0, 0, 0, tzinfo=datetime.timezone.utc))
/ datetime.timedelta(milliseconds=1)
)
)
Comment on lines
+977
to
+979
| self.assertEqual(result.created.timestamp() * 1000, 1437767599006) | ||
| self.assertEqual(result.started.timestamp() * 1000, 1437767600007) | ||
| self.assertEqual(result.ended.timestamp() * 1000, 1437767601008) |
Contributor
There was a problem hiding this comment.
I would recommend avoiding the cast to float of using timestamp(), this can introduce rounding errors.
4 tasks
This was referenced Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2261🦕