🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

Leak in truncate_racily_clean in index.c - #6884

Merged
ethomson merged 4 commits into
libgit2:mainfrom
lstoppa:fix-leak-for-index-when-git_diff_index_to_workdir-fails
Sep 20, 2024
Merged

Leak in truncate_racily_clean in index.c#6884
ethomson merged 4 commits into
libgit2:mainfrom
lstoppa:fix-leak-for-index-when-git_diff_index_to_workdir-fails

Conversation

@lstoppa

@lstoppa lstoppa commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

In truncate_racily_clean, when git_diff_index_to_workdir fails, we leak the local variable git_vector paths.

    In truncate_racily_clean, when git_diff_index_to_workdir fails,
    we leak the local variable git_vector paths.
@ethomson

Copy link
Copy Markdown
Member

Good catch; thanks!

@ethomson
ethomson merged commit 34432d9 into libgit2:main Sep 20, 2024
@lstoppa
lstoppa deleted the fix-leak-for-index-when-git_diff_index_to_workdir-fails branch September 20, 2024 21:50
@ethomson ethomson added the bug label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants