fix(bug): Main scrollbar jumps #5961 (process once only) - #10037
Merged
Conversation
YU000jp
changed the title
tiensonqin
requested review from
andelf,
logseq-cldwalker,
sprocketc and
xyhp915
August 17, 2023 10:10
YU000jp
changed the title
YU000jp
changed the title
2 tasks
Contributor
|
Before: After: |
Contributor
Author
|
Thank you. I tried it locally, but I'm not sure - if I was able to fully check all the functions. It is necessary to check the operation as it affects blocks and pages transitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5961 Still unresolved, this bug involves utilizing
useInViewhook to track if elements are within the visible screen. Yet, this leads to persistent monitoring even after the initial display, creating a cycle of observation during visibility toggling. Consequently, excessive scrolling ensues, causing notable CPU resource consumption.(#9963 (comment)) The recommended approach is to terminate monitoring once elements are initially displayed.Change