Repository navigation
Improve responsiveness to cmake changes made by vendors - #4908
Merged
Hannia Valera (hanniavalera) merged 2 commits intoApr 27, 2026
Conversation
Contributor
|
Julien D (@JDESTM) Thanks for putting this up, I appreciate the ongoing cooperation! |
Contributor
|
Had to address some minor lint errors + wanted to get you in the CHANGELOG :) let me know if these changes make sense to you! Julien D (@JDESTM) |
Julien D (JDESTM)
left a comment
Julien D (JDESTM)
left a comment
Contributor
Author
There was a problem hiding this comment.
My bad, I completely forgot to invoke the linter before pushing it, thanks for having fixed this 👍
Contributor
Author
|
@microsoft-github-policy-service agree company="STMicroelectronics International N.V." |
Signed-off-by: Julien Dehaudt <91720930+JDESTM@users.noreply.github.com>
Signed-off-by: Julien Dehaudt <91720930+JDESTM@users.noreply.github.com>
Julien D (JDESTM)
force-pushed
the
improve-responsiveness-to-cmake-changes-made-by-vendors
branch
from
April 24, 2026 19:19
ccc4db1 to
a9e387b
Compare
Hannia Valera (hanniavalera)
enabled auto-merge (squash)
April 27, 2026 19:34
Hannia Valera (hanniavalera)
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes improve responsiveness to
cmake.cmakePathconfiguration changes made by Vendors during the extension initialization phaseThe following changes are proposed:
onDidChangeConfigurationin the wait loop in addition tosetTimeout