worker: use _writev in internal communication

addaleax · codebytere · commit 64cae1379907 · 2020-06-18T08:05:20.000-07:00
PR-URL: #33454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/main/worker_thread.js b/lib/internal/main/worker_thread.js
@@ -167,8 +167,9 @@ port.on('message', (message) => {
       CJSLoader.Module.runMain(filename);
     }
   } else if (message.type === STDIO_PAYLOAD) {
-    const { stream, chunk, encoding } = message;
-    process[stream].push(chunk, encoding);
+    const { stream, chunks } = message;
+    for (const { chunk, encoding } of chunks)
+      process[stream].push(chunk, encoding);
   } else {
     assert(
       message.type === STDIO_WANTS_MORE_DATA,
diff --git a/lib/internal/worker.js b/lib/internal/worker.js
@@ -243,8 +243,11 @@ class Worker extends EventEmitter {
         return this[kOnErrorMessage](message.error);
       case messageTypes.STDIO_PAYLOAD:
       {
-        const { stream, chunk, encoding } = message;
-        return this[kParentSideStdio][stream].push(chunk, encoding);
+        const { stream, chunks } = message;
+        const readable = this[kParentSideStdio][stream];
+        for (const { chunk, encoding } of chunks)
+          readable.push(chunk, encoding);
+        return;
       }
       case messageTypes.STDIO_WANTS_MORE_DATA:
       {
diff --git a/lib/internal/worker/io.js b/lib/internal/worker/io.js
@@ -206,12 +206,11 @@ class WritableWorkerStdio extends Writable {
     this[kWritableCallbacks] = [];
   }
 
-  _write(chunk, encoding, cb) {
+  _writev(chunks, cb) {
     this[kPort].postMessage({
       type: messageTypes.STDIO_PAYLOAD,
       stream: this[kName],
-      chunk,
-      encoding
+      chunks: chunks.map(({ chunk, encoding }) => ({ chunk, encoding }))
     });
     this[kWritableCallbacks].push(cb);
     if (this[kPort][kWaitingStreams]++ === 0)
@@ -222,7 +221,7 @@ class WritableWorkerStdio extends Writable {
     this[kPort].postMessage({
       type: messageTypes.STDIO_PAYLOAD,
       stream: this[kName],
-      chunk: null
+      chunks: [ { chunk: null, encoding: '' } ]
     });
     cb();
   }

Original file line number	Diff line number	Diff line change
`@@ -243,8 +243,11 @@ class Worker extends EventEmitter {`
`243`	`243`	`return this[kOnErrorMessage](message.error);`
`244`	`244`	`case messageTypes.STDIO_PAYLOAD:`
`245`	`245`	`{`
`246`		`- const { stream, chunk, encoding } = message;`
`247`		`- return this[kParentSideStdio][stream].push(chunk, encoding);`
	`246`	`+ const { stream, chunks } = message;`
	`247`	`+ const readable = this[kParentSideStdio][stream];`
	`248`	`+ for (const { chunk, encoding } of chunks)`
	`249`	`+ readable.push(chunk, encoding);`
	`250`	`+ return;`
`248`	`251`	`}`
`249`	`252`	`case messageTypes.STDIO_WANTS_MORE_DATA:`
`250`	`253`	`{`