src: cache context lookup in vectored io loops

mertcanaltin · aduh95 · commit 977f46cc20ed · 2026-01-27T22:52:31.000+01:00
PR-URL: #61387 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/src/env-inl.h b/src/env-inl.h
@@ -897,7 +897,7 @@ v8::Local<v8::Context> Environment::context() const {
   return principal_realm()->context();
 }
 
-Realm* Environment::principal_realm() const {
+PrincipalRealm* Environment::principal_realm() const {
   return principal_realm_.get();
 }
 
diff --git a/src/env.h b/src/env.h
@@ -881,7 +881,7 @@ class Environment final : public MemoryRetainer {
   // Get the context with an explicit realm instead when possible.
   // Deprecate soon.
   inline v8::Local<v8::Context> context() const;
-  inline Realm* principal_realm() const;
+  inline PrincipalRealm* principal_realm() const;
 
 #if HAVE_INSPECTOR
   inline inspector::Agent* inspector_agent() const {
diff --git a/src/node_realm-inl.h b/src/node_realm-inl.h
@@ -5,6 +5,7 @@
 
 #include "node_context_data.h"
 #include "node_realm.h"
+#include "util-inl.h"
 
 namespace node {
 
@@ -46,6 +47,10 @@ inline v8::Isolate* Realm::isolate() const {
   return isolate_;
 }
 
+inline v8::Local<v8::Context> Realm::context() const {
+  return PersistentToLocal::Strong(context_);
+}
+
 inline Realm::Kind Realm::kind() const {
   return kind_;
 }
diff --git a/src/node_realm.cc b/src/node_realm.cc
@@ -295,10 +295,6 @@ void Realm::VerifyNoStrongBaseObjects() {
   });
 }
 
-v8::Local<v8::Context> Realm::context() const {
-  return PersistentToLocal::Strong(context_);
-}
-
 // Per-realm strong value accessors. The per-realm values should avoid being
 // accessed across realms.
 #define V(PropertyName, TypeName)                                              \
diff --git a/src/node_realm.h b/src/node_realm.h
@@ -121,7 +121,7 @@ class Realm : public MemoryRetainer {
   inline Environment* env() const;
   inline v8::Isolate* isolate() const;
   inline Kind kind() const;
-  virtual v8::Local<v8::Context> context() const;
+  inline virtual v8::Local<v8::Context> context() const;
   inline bool has_run_bootstrapping_code() const;
 
   // Methods created using SetMethod(), SetPrototypeMethod(), etc. inside

Original file line number	Diff line number	Diff line change
`@@ -897,7 +897,7 @@ v8::Local<v8::Context> Environment::context() const {`
`897`	`897`	`return principal_realm()->context();`
`898`	`898`	`}`
`899`	`899`
`900`		`-Realm* Environment::principal_realm() const {`
	`900`	`+PrincipalRealm* Environment::principal_realm() const {`
`901`	`901`	`return principal_realm_.get();`
`902`	`902`	`}`
`903`	`903`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`
`6`	`6`	`#include "node_context_data.h"`
`7`	`7`	`#include "node_realm.h"`
	`8`	`+#include "util-inl.h"`
`8`	`9`
`9`	`10`	`namespace node {`
`10`	`11`
`@@ -46,6 +47,10 @@ inline v8::Isolate* Realm::isolate() const {`
`46`	`47`	`return isolate_;`
`47`	`48`	`}`
`48`	`49`
	`50`	`+inline v8::Local<v8::Context> Realm::context() const {`
	`51`	`+ return PersistentToLocal::Strong(context_);`
	`52`	`+}`
	`53`	`+`
`49`	`54`	`inline Realm::Kind Realm::kind() const {`
`50`	`55`	`return kind_;`
`51`	`56`	`}`