🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

test_runner: support combining coverage reports#47686

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cjihrig:coverage
Apr 28, 2023
Merged

test_runner: support combining coverage reports#47686
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cjihrig:coverage

Conversation

@cjihrig

@cjihrig cjihrig commented Apr 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This commit adds support for combining code coverage reports in the test runner. This allows coverage to be collected for child processes, and by extension, the test runner CLI.

Fixes: #47669

Notable change text:

Code coverage obtained from multiple processes via --experimental-test-coverage can now be combined into a single report. This allows code coverage to be used with --test.

@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Apr 23, 2023
@cjihrig cjihrig force-pushed the coverage branch 2 times, most recently from 12b34fc to cf410eb Compare April 23, 2023 18:06
ljharb
ljharb reviewed Apr 23, 2023
View reviewed changes
Comment thread lib/internal/test_runner/coverage.js
MoLow
MoLow reviewed Apr 24, 2023
View reviewed changes
Comment thread test/parallel/test-runner-coverage.js Outdated
MoLow
MoLow reviewed Apr 24, 2023
View reviewed changes
Comment thread test/parallel/test-runner-coverage.js Outdated
MoLow
MoLow reviewed Apr 24, 2023
View reviewed changes
Comment thread test/parallel/test-runner-coverage.js Outdated
MoLow
MoLow reviewed Apr 24, 2023
View reviewed changes
Comment thread test/parallel/test-runner-coverage.js Outdated
MoLow
MoLow reviewed Apr 24, 2023
View reviewed changes
Comment thread lib/internal/test_runner/coverage.js
MoLow
MoLow approved these changes Apr 24, 2023
View reviewed changes

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. made some non blocking suggestions

MoLow
MoLow reviewed Apr 24, 2023
View reviewed changes
Comment thread test/parallel/test-runner-cli.js Outdated
@cjihrig
test_runner: support combining coverage reports
450d297 
This commit adds support for combining code coverage reports
in the test runner. This allows coverage to be collected for
child processes, and by extension, the test runner CLI.
@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51523/

@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51524/

@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51526/

@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51527/

@cjihrig cjihrig added semver-minor PRs that contain new features and should be released in the next minor version. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Apr 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47686
✔  Done loading data for nodejs/node/pull/47686
----------------------------------- PR info ------------------------------------
Title      test_runner: support combining coverage reports (#47686)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cjihrig:coverage -> nodejs:main
Labels     c++, semver-minor, dont-land-on-v14.x, test_runner
Commits    1
 - test_runner: support combining coverage reports
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/47686
Fixes: https://github.com/nodejs/node/issues/47669
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47686
Fixes: https://github.com/nodejs/node/issues/47669
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 23 Apr 2023 14:48:07 GMT
   ✔  Approvals: 1
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/47686#pullrequestreview-1405267514
   ✘  This PR needs to wait 49 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-04-28T05:50:34Z: https://ci.nodejs.org/job/node-test-pull-request/51527/
- Querying data for job/node-test-pull-request/51527/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4830925765

@cjihrig cjihrig removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 28, 2023
mcollina
mcollina approved these changes Apr 28, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot mentioned this pull request May 2, 2023
Open
32 tasks
@targos targos mentioned this pull request May 2, 2023
Merged
@github-actions github-actions Bot mentioned this pull request May 3, 2023
Open
33 tasks
@github-actions github-actions Bot mentioned this pull request May 4, 2023
Open
28 tasks
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments
@mcollina mcollina mcollina approved these changes
@MoLow MoLow MoLow approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--experimental-test-coverage cannot be used with --test

5 participants

@cjihrig @nodejs-github-bot @ljharb @mcollina @MoLow