🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

Update shipmonk-rnd/dead-code-detector to fix integration tests - #15053

Merged
staabm merged 3 commits into
phpstan:2.2.xfrom
staabm:fix-dead
Aug 6, 2026
Merged

Update shipmonk-rnd/dead-code-detector to fix integration tests#15053
staabm merged 3 commits into
phpstan:2.2.xfrom
staabm:fix-dead

Conversation

@staabm

@staabm staabm commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

fixes

There were 2 failures:

1) ShipMonk\PHPStan\DeadCode\Rule\DeadCodeRuleTest::testDead with data set "provider-vendor" ('/home/runner/work/phpstan-src...or.php')
Errors in file /home/runner/work/phpstan-src/phpstan-src/e2e/integration/repo/tests/Rule/data/providers/vendor.php do not match:

New errors reported:
18: Unused Default\MyPropertiesExtensionProvider::EXTENSION_TAG


Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'34: Unused Default\MyRule::unused
+'18: Unused Default\MyPropertiesExtensionProvider::EXTENSION_TAG
+34: Unused Default\MyRule::unused
 58: Property Default\MyTest::$dead is never read
 58: Property Default\MyTest::$dead is never written
 '

/home/runner/work/phpstan-src/phpstan-src/e2e/integration/repo/vendor/shipmonk/phpstan-dev/src/RuleTestCase.php:73
/home/runner/work/phpstan-src/phpstan-src/e2e/integration/repo/tests/Rule/DeadCodeRuleTest.php:252
/home/runner/work/phpstan-src/phpstan-src/e2e/integration/repo/tests/Rule/DeadCodeRuleTest.php:178

2) ShipMonk\PHPStan\DeadCode\Rule\DeadCodeRuleTest::testDeadWithGroups with data set "provider-vendor" ('/home/runner/work/phpstan-src...or.php')
Errors in file /home/runner/work/phpstan-src/phpstan-src/e2e/integration/repo/tests/Rule/data/providers/vendor.php do not match:

New errors reported:
18: Unused Default\MyPropertiesExtensionProvider::EXTENSION_TAG


Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'34: Unused Default\MyRule::unused
+'18: Unused Default\MyPropertiesExtensionProvider::EXTENSION_TAG
+34: Unused Default\MyRule::unused
 58: Property Default\MyTest::$dead is never read
 58: Property Default\MyTest::$dead is never written
 '

/home/runner/work/phpstan-src/phpstan-src/e2e/integration/repo/vendor/shipmonk/phpstan-dev/src/RuleTestCase.php:73
/home/runner/work/phpstan-src/phpstan-src/e2e/integration/repo/tests/Rule/DeadCodeRuleTest.php:252
/home/runner/work/phpstan-src/phpstan-src/e2e/integration/repo/tests/Rule/DeadCodeRuleTest.php:191

FAILURES!
Tests: 718, Assertions: 3898, Failures: 2, Skipped: 1.
Error: Process completed with exit code 1.

@staabm
staabm marked this pull request as ready for review August 6, 2026 09:01
@staabm
staabm merged commit 62a06c2 into phpstan:2.2.x Aug 6, 2026
163 of 165 checks passed
@staabm
staabm deleted the fix-dead branch August 6, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant