Disable zend.assertions as suggested by PHPParser - #6021
Merged
Conversation
staabm
marked this pull request as ready for review
July 8, 2026 09:14
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
approved these changes
Jul 8, 2026
VincentLanglet
left a comment
Contributor
There was a problem hiding this comment.
Might be worth having the go from ondrej
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nikic/PHP-Parser Performance.markdown suggests to use
zend.assertions=0at runtime.at best the php.ini of the php binary beeing used would define
zend.assertions=-1, but thats neither the default php ships with in development nor is it likely people will adjust this setting in a environment in which PHPStan is runningquoting the php.ini:
so with this PR we disable zend-asserts at runtime in case they are not disabled entirely by the used php.ini setting already.
testing on https://github.com/TomasVotruba/php-parser-speed-comparison-2026 suggests this has some small benefit