Repository navigation
馃悰 fix(create): validate resolved destination paths - #3399
Merged
gaborbernat merged 3 commits intoOct 16, 2026
Merged
Conversation
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative destinations could pass validation even when their absolute path contained the platform's PATH separator. 馃悰 An environment created as
envbeneath a directory containing:on POSIX or;on Windows could then produce an activation PATH that split the environment directory into separate entries.Validate the path used by activation
The previous validation checked only the supplied argument before resolving it. The fix checks both the supplied path and the resolved destination, covering separators inherited from the working directory or a directory symlink.
Behavior changes
Virtualenv now rejects these destinations before creating the environment and reports the path containing the separator. Choose a destination whose resolved path contains no PATH separator. The existing rejection of separators supplied directly in the argument remains in place.