Repository navigation
馃悰 fix(activate): preserve Unicode with legacy readers - #3402
Merged
Merged
Conversation
gaborbernat
added
the
security
gaborbernat
removed
the
security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications that read
activate_this.pywith a legacy text encoding could change non-ASCII prompt and path values before executing the script. 馃悰 Generated string literals now use ASCII escape sequences, preserving their Unicode values across UTF-8, Latin-1 and CP932 decoding.Keep generated literals independent of the text reader
The previous quoting used
repr, which leaves printable non-ASCII characters in the source. The fix uses Python's ASCII string representation. Python reconstructs the original characters when it evaluates those literals.Behavior changes
Generated literals contain escapes for non-ASCII characters. Their values after evaluation remain unchanged. Applications can continue using the documented
runpy.run_pathactivation method.