Repository navigation
馃悰 fix(seed): reject invalid and archive-like versions - #3403
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed seed versions could reach pip and produce a local-file error instead of a version-validation error. 馃悰 Virtualenv now validates version syntax before downloading and rejects requirements ending in archive suffixes.
Validate meaning as well as characters
The previous check allowed a set of characters without parsing a version. The fix also uses packaging's specifier parser. A separate check rejects archive suffixes because a valid local version can still make the assembled requirement look like an archive to pip.
Behavior changes
Invalid versions fail before pip starts. Local versions ending in an archive suffix are also rejected, including case variants; other local version labels remain supported. The existing supported operators and rejection of whitespace remain unchanged.