fix(admin): open billing portal in same tab to reflect edits on return - #1722

web/sdk/admin/views/organizations/details/side-panel/billing-details-section.tsx (2)

94-107: 🎯 Functional Correctness | 🔵 Trivial | 🏗️ Heavy lift

One-shot refresh flag may leave data stale on repeated portal round-trips.

portalOpenedRef.current is reset to false the moment the tab becomes visible again, so only the first return from the Stripe portal triggers a refetch. If the user keeps the portal tab open and toggles back to the admin tab multiple times while still editing (e.g., checks something in admin, returns to the portal, edits the address further, comes back again), subsequent returns won't refresh — reintroducing the exact stale-data problem this PR is meant to fix.

Consider not resetting the flag until the portal tab is actually known to be closed (e.g., track the portalTab/window reference and poll .closed, or listen for its unload/pagehide), so every return-to-tab visit while the portal is still open triggers a refresh.

💡 Illustrative approach

-  useEffect(() => {
-    const handleVisibilityChange = () => {
-      if (document.visibilityState === "visible" && portalOpenedRef.current) {
-        portalOpenedRef.current = false;
-        fetchBillingAccountDetails();
-      }
-    };
+  useEffect(() => {
+    const handleVisibilityChange = () => {
+      if (document.visibilityState === "visible" && portalOpenedRef.current) {
+        fetchBillingAccountDetails();
+        // Only stop refreshing once the portal tab itself has been closed.
+        if (portalTabRef.current?.closed) {
+          portalOpenedRef.current = false;
+        }
+      }
+    };
     document.addEventListener("visibilitychange", handleVisibilityChange);
     return () => {
       document.removeEventListener("visibilitychange", handleVisibilityChange);
     };
   }, [fetchBillingAccountDetails]);

---

100-100: 🩺 Stability & Availability | 🔵 Trivial | 💤 Low value

Unhandled rejection risk on fetchBillingAccountDetails().

The refetch promise is fired without a .catch/await. If it rejects, this could surface as an unhandled promise rejection.

🛡️ Proposed fix

-        fetchBillingAccountDetails();
+        fetchBillingAccountDetails()?.catch(() => {
+          // errors are already surfaced via the query's error state
+        });