🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

fix(admin): use blue IAM mark as favicon - #1729

Merged
rohilsurana merged 1 commit into
mainfrom
fix/admin-favicon
Jul 2, 2026
Merged

fix(admin): use blue IAM mark as favicon#1729
rohilsurana merged 1 commit into
mainfrom
fix/admin-favicon

Conversation

@Shreyag02

Copy link
Copy Markdown
Contributor

Summary

The admin app's favicon was missing — browsers showed no tab icon. The in index.html pointed at /vite.svg, which doesn't exist in the app's public/ directory. This PR points the favicon at the blue IAM brand mark so the tab icon matches the login/sidebar branding

Changes

  • Copied the blue IAM mark (src/assets/icons/iam.svg, fill="#3E63DD") into public/iam.svg so Vite serves it as a static asset at /iam.svg.
  • Updated index.html favicon reference from the non-existent /vite.svg to /iam.svg.

Technical Details

  • The IAM mark previously existed only in src/assets/icons/ and was imported as a React component (iam.svg?react) for the login and sidebar — it wasn't available as a servable static file for use in index.html. Favicons referenced from index.html must resolve to a static file, so a copy in public/ is the conventional Vite approach.
  • The original src/ copy is left untouched; the React imports in Sidebar/login/magiclink are unaffected. There's a public/logo.svg, but it's a plain shield with a near-black fill (#171717), not the blue brand mark, so it wasn't used.
  • Change is fully isolated to the admin app: the SDK has no favicon/index.html references, and public/* is copied verbatim into dist/admin (embedded via embed.go) with no naming collision.

Test Plan

  • Manual testing completed
  • Build and type checking passes

SQL Safety (if your PR touches *_repository.go or goqu.*)

N/A

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jul 2, 2026 10:38am

@Shreyag02
Shreyag02 requested a review from rohanchkrabrty July 2, 2026 10:38
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6eaf22af-ef15-4c70-a683-eb12cccaa77b

📥 Commits

Reviewing files that changed from the base of the PR and between 46c7170 and c3871e6.

⛔ Files ignored due to path filters (1)
  • web/apps/admin/public/iam.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • web/apps/admin/index.html

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Updated the admin app’s browser tab icon to a new favicon.

Walkthrough

The admin app's index.html favicon link is updated to reference /iam.svg instead of /vite.svg.

Changes

Favicon Update

Layer / File(s) Summary
Update favicon reference
web/apps/admin/index.html
The favicon <link rel="icon"> href is changed from /vite.svg to /iam.svg.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related PRs: None identified

Suggested labels: None

Suggested reviewers: None

Poem:
A hop, a skip, a tiny fix,
One icon swapped among the bricks,
Vite's star gives way to IAM's own,
A single line, a favicon shown. 🐰

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 28583808407

Warning

No base build found for commit 46c7170 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 44.833%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 37604
Covered Lines: 16859
Line Coverage: 44.83%
Coverage Strength: 12.49 hits per line

💛 - Coveralls

@rohilsurana
rohilsurana merged commit 4a8d725 into main Jul 2, 2026
8 checks passed
@rohilsurana
rohilsurana deleted the fix/admin-favicon branch July 2, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants