fix(resource): use resource title as audit record target name - #1833
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe resource service now uses a resource title for audit target names when present and falls back to the resource name when the title is empty. Tests cover both cases. ChangesResource audit target naming
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Audit records for resource creation stored the resource's unique name, which callers often set to an ID. Store the title instead and fall back to the name when the title is empty. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AmanGIT07
force-pushed
the
fix/audit-resource-target-title
branch
from
August 3, 2026 08:53
bac5c0e to
d4a540b
Compare
Coverage Report for CI Build 30799138158Coverage increased (+0.005%) to 47.549%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
rohilsurana
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit records for resource creation stored the resource's machine name, which callers often set to an ID. The record now stores the resource title as the target name and falls back to the name when the title is empty.
Changes
core/resource/service.go:createAuditRecordsets the target name fromTitle, falling back toNamewhen the title is empty.core/resource/service_test.go: subtests covering the title case and the empty-title fallback.Test Plan
go test -race ./core/resource/...passesgolangci-lint run ./core/resource/...reports 0 issues🤖 Generated with Claude Code