MCP Update tool - #5952
Conversation
65d52b8 to
3619e45
Compare
|
Let's do the thing where we mark it as destructive but otherwise don't block. |
|
Even if it did delete a branch I think you could still get it back with the global reflog, but obviously not ideal. Okay sounds like a plan 👍🏼 |
3619e45 to
cda78b2
Compare
|
@aryairani Okay I removed the branch-protection stuff. |
|
I'm dogfooding it now 👍 |
aryairani
left a comment
aryairani
left a comment
There was a problem hiding this comment.
Sorry for the delay and ensuing conflicts; this is great. Could you update the PR description to confirm --mcp-editable-branches= isn't a thing anymore; can just strikeout it if desired
93f7a43 to
872ac93
Compare
2 participants
Overview
This requires the user to explicitly mark a branch as editable by the mcp by passing theNow we just rely on the agent respecting the 'destructive updates' flag, caveat emptor.--mcp-editable-branches=<project/branch regex>flag in their MCP config. We can continue to explore other options for this.Implementation notes
Adds the new global--mcp-editable-branches=<project/branch regex>flagupdatetoolTest coverage
Added an API transcript test
Could use some dogfooding and testing in the wile before merging/releasing
Loose ends
May want to explore other methods of allowing mcp edits on certain branches, editing your config file and restarting your agent every time is a pain.