Convert a bunch of types and functions from String -> Text - #5958
Merged
Conversation
ChrisPenner
marked this pull request as ready for review
October 23, 2025 00:25
aryairani
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Sorry, I know this is annoying and spans a big chunk of the codebase.
Switches a bunch of stuff from String -> Text;
We're still using
Stringin a lot of low-level stuff, which is going to be inefficient both in memory and cpu when doing a bunch of text munging.Specifically I wanted to switch AnnotatedText to actually use Text so I can use Text primitives when working with it (without needing to switch back and forth a bunch).
I'll be building some of the diffing improvements on top of this.
Implementation notes
Test coverage
Existing tests