README: Fix factorial example - #5998
Merged
Merged
Conversation
aryairani
approved these changes
Nov 10, 2025
aryairani
left a comment
aryairani
left a comment
Contributor
There was a problem hiding this comment.
oops, that's embarrassing Thanks for the fix.
Could you add yourself to contributors.md to indicate acceptance of Unison's MIT license?
Author
|
Sure thing - it's done 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
factorialexample in theREADME.mddid not actually compute the factorial: It was a product including 0, i.e. always 0. I fixed the range.Implementation approach and notes
N/A
Interesting/controversial decisions
N/A
Test coverage
N/A
Loose ends
N/A