Fix ctrl-c on pager - #6187
Merged
Merged
Conversation
ChrisPenner
force-pushed
the
cp/fix-pager-procs
branch
from
March 16, 2026 22:39
caa1c30 to
1955728
Compare
ChrisPenner
force-pushed
the
cp/fix-pager-procs
branch
from
March 17, 2026 20:18
9b49994 to
743e2a2
Compare
Contributor
|
lol what! |
Member
Author
|
@aryairani Okay I've got it passing without cheating this time :P |
Contributor
|
I thought mine should have matched too |
aryairani
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Discovered that we fail to clean up broken stdin/stdout handles if the user
ctrl-c's a pager process; causing issues like thisImplementation approach and notes
Use
withCreateProcessinstead, which cleans up after exceptions/interrupts.Did the same for FZF calls just in case :)
Test coverage
Tested ctrl-c on pagers manually, trunk always gets broken, this is fixed.