LSP - Fix prefixing on type sig hints - #6188
Merged
Merged
Conversation
Member
Author
|
I take it back, can't leave it in verbose mode because the CI script currently matches directly on the stdout message rather than exit code; so the verbose output breaks the result. |
ChrisPenner
marked this pull request as ready for review
March 17, 2026 21:40
ChrisPenner
force-pushed
the
cp/prefixed-type-sigs
branch
from
March 19, 2026 20:33
b9976d2 to
ddb05bb
Compare
aryairani
approved these changes
Mar 27, 2026
Contributor
|
@ChrisPenner I made a few fixes (hopefully improvements) to the CI stuff, but I want to know if it works now from your machine. Can you re-pull and re-run |
ChrisPenner
force-pushed
the
cp/prefixed-type-sigs
branch
from
April 10, 2026 17:38
4388a27 to
a752df2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
On trunk, type signature hints didn't understand the top-level
namespacedirective, now they do.On trunk:
This branch:
Implementation approach and notes
Testing
Tested manually