Add signature command - #6225
Merged
Merged
Conversation
ChrisPenner
force-pushed
the
cp/signature-command
branch
from
April 23, 2026 22:25
104381f to
c8cad0d
Compare
ChrisPenner
commented
Apr 23, 2026
| cd "$SCRIPTDIR/.." | ||
| find . -name '*.hs' \ | ||
| -not -path "*/dist-newstyle/*" \ | ||
| -not -path "*/.stack-work*/*" -print0 \ |
Member
Author
There was a problem hiding this comment.
I have a custom lsp.stack-work for HLS which was causing formatting to fail, this should work in both cases.
Contributor
There was a problem hiding this comment.
I see. I wish we had a better solution for these one-offs, because anyone can make up any path.
pchiusano
approved these changes
Apr 23, 2026
aryairani
reviewed
Apr 23, 2026
Agent-Logs-Url: https://github.com/unisonweb/unison/sessions/9089bfa4-f817-4585-a056-c8fb0e9d921a Co-authored-by: aryairani <538571+aryairani@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Note: this PR is largely vibe-coded; however I did double-check the whole implementation
At some point
viewwas changed to also show documentation, this is sometimes nice, but also makes it pretty annoying to just see the type signature of a term when you want to. Maybe docs shouldn't be included inview, but this PR takes a different approach of just adding asignaturecommand which shows the type of any term or constructor.Implementation approach and notes
signaturecommand which just renders the type of a definition.Test coverage