date: fix -s UTC conversion losing timezone offset - #10828
Merged
Conversation
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Feb 11, 2026
| @@ -454,6 +454,21 @@ fn test_date_set_valid_2() { | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg(all(unix, not(any(target_os = "android", target_os = "macos"))))] | |||
| fn test_date_set_utc_with_offset() { | |||
Collaborator
There was a problem hiding this comment.
I don't think this actually tests anything, it just checks to see if the user is root and fails. Maybe it would be better to add a unit test for this for the conversion?
Collaborator
There was a problem hiding this comment.
I see there's other integration tests in here that use the -s flag, can you follow the format of those tests?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! Replaced the integration test with a unit test that verifies the conversion directly.
|
GNU testsuite comparison: |
yachi
force-pushed
the
fix-date-set-utc-conversion
branch
from
February 12, 2026 22:11
d84e70b to
b760fd7
Compare
yachi
marked this pull request as draft
February 12, 2026 22:25
|
GNU testsuite comparison: |
yachi
force-pushed
the
fix-date-set-utc-conversion
branch
from
February 14, 2026 13:29
b760fd7 to
d460a72
Compare
yachi
marked this pull request as ready for review
February 14, 2026 13:43
|
GNU testsuite comparison: |
yachi
marked this pull request as draft
February 14, 2026 14:00
yachi
force-pushed
the
fix-date-set-utc-conversion
branch
from
February 14, 2026 15:52
d460a72 to
faa9945
Compare
yachi
marked this pull request as ready for review
February 14, 2026 15:54
Collaborator
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10800
-swith-ureinterpreted wall-clock time as UTC, losing the timezone offset. Extracted the conversion into a helper to make it testable and fixed it to preserve the absolute instant.