🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

cp: fix Ioctl casting for ppc64 (Closes: #8161) - #8637

Merged
sylvestre merged 1 commit into
uutils:mainfrom
maxfilov:main
Sep 14, 2025
Merged

cp: fix Ioctl casting for ppc64 (Closes: #8161)#8637
sylvestre merged 1 commit into
uutils:mainfrom
maxfilov:main

Conversation

@maxfilov

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

Comment thread src/uu/cp/src/platform/linux.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the now obsolete comment.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sylvestre

Copy link
Copy Markdown
Contributor

please run
cargo fmt

@sylvestre

Copy link
Copy Markdown
Contributor

also, it would be nice to have CI for this to make sure we don't regress

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@sylvestre
sylvestre merged commit 8c31f39 into uutils:main Sep 14, 2025
95 checks passed
@maxfilov

maxfilov commented Sep 14, 2025

Copy link
Copy Markdown
Author

@sylvestre

  1. cargo fmt ✔️
  2. I'm not sure I understand completely what "to have CI" means. Should I do something?
  3. Also I thought about some Unit Tests, but I'm not sure it is doable in sane amount of efforts. I'm thinking about that.

@sylvestre

Copy link
Copy Markdown
Contributor

have a new job in github action to build on ppc64

@maxfilov

maxfilov commented Sep 14, 2025

Copy link
Copy Markdown
Author

@sylvestre I will try, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants