🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

Investigate if sandboxing flag check can move to the PresentationRequest ctor #379

Closed

Description

@markafoltz

Follow-up from Issue #362. It may be possible to check the sandboxing flag in the ctor for PresentationRequest, and this would simplify the algorithms that check it on function invocation.

However, if the attribute is dynamic or set on navigation, it may not be possible.

@mounirlamouri can you update this with what you discover in Blink?

Activity

  1. mounirlamouri commented on Nov 30, 2016

    @mounirlamouri
    Member

    Looking at Blink code, it seems to be dynamic. My understanding of the spec is that it's not.

    @annevk do I misinterpret the spec?

  2. annevk commented on Nov 30, 2016

    @annevk
    Member

    I don't really understand the sandboxing setup. Too much forwarding of state.

  3. markafoltz commented on Dec 1, 2016

    @markafoltz
    ContributorAuthor

    Well, it would be safest to check it in both the PresentationRequest ctor and its functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions