🌐 US-Proxy
class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

[PHP 8] Add properties argument to __set_state magic method - #5469

Merged
schlessera merged 1 commit into
wp-cli:masterfrom
TimothyBJacobs:patch-1
Nov 12, 2020
Merged

[PHP 8] Add properties argument to __set_state magic method#5469
schlessera merged 1 commit into
wp-cli:masterfrom
TimothyBJacobs:patch-1

Conversation

@TimothyBJacobs

Copy link
Copy Markdown
Contributor

On PHP 8 a fatal error is issued if a magic method doesn't match the expected signature.

PHP Fatal error:  Method Test_Magic_Methods::__set_state() must take exactly 1 argument

@TimothyBJacobs
TimothyBJacobs requested a review from a team as a code owner November 11, 2020 18:44
@schlessera schlessera added the scope:testing Related to testing label Nov 12, 2020
@schlessera schlessera added this to the 2.5.0 milestone Nov 12, 2020
@schlessera
schlessera merged commit 6af36bf into wp-cli:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants