Fix breaking multi-line CSV values on reading - #5939
Merged
danielbachhuber merged 2 commits intoApr 26, 2024
Merged
Conversation
Member
|
Related: #5935 |
danielbachhuber
requested changes
Apr 26, 2024
Member
There was a problem hiding this comment.
Thanks for the PR, @Takshil-Kunadia !
Can you include some tests for this change? PHPUnit or Behat tests would be fine.
Contributor
Author
|
Thanks! @danielbachhuber . I have added Unit test for CSV Iterator and added basic tests along with the test that covers the intended scenario. Please review... |
mrsdizzie
approved these changes
Apr 26, 2024
danielbachhuber
approved these changes
Apr 26, 2024
danielbachhuber
left a comment
danielbachhuber
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR and the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5412