Repository navigation
fix(server): reject terminal-task operations with UnsupportedOperationError - #1268
Merged
Merged
Conversation
🧪 Code Coverage (vs
|
JakubWorek
added this pull request to stack #1275
September 23, 2026 12:55
JakubWorek
marked this pull request as ready for review
September 23, 2026 13:26
Contributor
|
#1178 adds a terminal-state check in |
mykytanetipa
approved these changes
Sep 27, 2026
…nError Spec 3.1.1 and 3.3.2 name UnsupportedOperationError for operations on a task in a terminal state; ActiveTask raised InvalidParamsError instead, so send_message and subscribe_to_task both returned -32602 rather than -32004. The legacy handler already answered subscribe correctly, which is why only the v2 path drifted. on_cancel_task keeps its TaskNotCancelableError remap, now keyed on the new error. Adds the v2 subscribe-to-terminal test whose absence let the divergence survive.
JakubWorek
force-pushed
the
jakubworek/acts-terminal-state-error
branch
from
September 28, 2026 10:14
ce95dff to
aaa88b6
Compare
mykytanetipa
pushed a commit
that referenced
this pull request
Sep 29, 2026
🤖 I have created a release *beep* *boop* --- ## [1.2.0](v1.1.5...v1.2.0) (2026-09-29) ### Features * **rest:** serve HTTP+JSON responses as application/a2a+json ([#1274](#1274)) ([dc5a5da](dc5a5da)) * **server:** add caching headers to the agent card endpoint ([#1272](#1272)) ([83d7f5d](83d7f5d)) * **server:** add multi-replica cluster mode ([#1281](#1281)) ([942d621](942d621)) * **server:** add opt-in validation of message media types against the agent card ([#1269](#1269)) ([8037b24](8037b24)) ### Bug Fixes * compare in-memory task timestamps numerically ([#1233](#1233)) ([0d5473c](0d5473c)) * **server:** ignore unrecognized request fields and fix parse-error data shape ([#1273](#1273)) ([83f1cf8](83f1cf8)) * **server:** reject a message whose contextId disagrees with its task ([#1270](#1270)) ([c25022f](c25022f)) * **server:** reject terminal-task operations with UnsupportedOperationError ([#1268](#1268)) ([6cce91b](6cce91b)) * **server:** send PushNotificationConfig.authentication as an Authorization header ([#1271](#1271)) ([5751d31](5751d31)), closes [#585](#585) ### Documentation * **samples:** add Agent Card signing sample ([#1198](#1198)) ([f3ac824](f3ac824)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Spec 3.1.1 names
UnsupportedOperationErrorfor "Messages sent to Tasks that are in a terminal state", and 3.3.2 repeats it for any operation on a terminal task. 5.4 maps that to-32004/FAILED_PRECONDITION/ HTTP 400.ActiveTaskraisedInvalidParamsError(-32602) instead, at all three of its terminal-state guards.That covers both
send_messageandsubscribe_to_task, becauseDefaultRequestHandlerV2.on_subscribe_to_taskhas no terminal check of its own: it callsget_or_create, which callsActiveTask.start(), and the error surfaces out of the first__anext__.Worth knowing while reading:
DefaultRequestHandleris an alias forDefaultRequestHandlerV2(request_handlers/__init__.py:46), sodefault_request_handler.pyis the legacy handler and is not on the default path. It already answered subscribe correctly at line 613, which is why only the v2 path drifted. Its send path is corrected here too, so the two handlers and the two operations finally agree.Cancel keeps its own error
on_cancel_taskdeliberately catchesActiveTask's terminal-state error and re-raisesTaskNotCancelableError, which 3.3.2 gives its own entry. That remap is retained, now keyed on the new error type. Two ACTS tests (CORE-CANCEL-002,CORE-ERR-002) cover it and still pass.Tests
test_on_subscribe_to_task_in_terminal_stateis new for v2. Its absence is why this survived: the legacy suite had the equivalent test and asserted the correct error all along, so the divergence never showed up. Mutation-checked - revertingactive_task.py:472alone fails all four parametrized cases.An existing
# TODO: Is it correct error code ?intest_scenarios.pysat next to this exact assertion. It is now answered rather than carried forward.Result
Clears
CORE-SEND-002,CORE-ERR-004andSTREAM-SUB-003(allmust) on jsonrpc, grpc and rest - 9 of the 21 failing MUST test-instances.