Fix Windows launcher classpath - #3373
Merged
Merged
Conversation
pratushnyi
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
After #3309, the generated Windows launcher for Allure Commandline uses an explicit jar-by-jar classpath instead of a short wildcard classpath.
In Allure Commandline 2.42.0, bin/allure.bat contains a single set CLASSPATH=... line that repeats %APP_HOME% once per jar. The current line is about 2127 chars before expansion and contains 51 %APP_HOME% entries.
On Windows, cmd.exe has an effective command line limit of 8191 characters. After %APP_HOME% expansion, the launcher can exceed that limit when Allure is installed under a long path.
Approximate formula for 2.42.0:
text
expanded_length = 1617 + 51 * length(APP_HOME)
So the launcher becomes risky once APP_HOME is around 129+ characters.
Checklist