refactor(site/src): extract shared workspace-app frame module - #26088
Merged
Conversation
Member
Author
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
from
June 5, 2026 02:52
67ace3c to
50f50c2
Compare
ethanndickson
changed the base branch from
graphite-base/26088
to
ethan/agents-multi-terminal-tabs
June 5, 2026 02:52
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
from
June 5, 2026 03:54
50f50c2 to
259222f
Compare
ethanndickson
force-pushed
the
ethan/agents-multi-terminal-tabs
branch
2 times, most recently
from
June 5, 2026 04:25
debb4a0 to
6589f87
Compare
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
2 times, most recently
from
June 5, 2026 07:49
5cda3d4 to
2dd2708
Compare
ethanndickson
force-pushed
the
ethan/agents-multi-terminal-tabs
branch
2 times, most recently
from
June 5, 2026 10:21
20f5d3d to
1401838
Compare
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
2 times, most recently
from
June 9, 2026 03:10
3680c09 to
c0db8fe
Compare
ethanndickson
force-pushed
the
ethan/agents-multi-terminal-tabs
branch
2 times, most recently
from
June 9, 2026 03:46
a055112 to
e7f2e8b
Compare
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
2 times, most recently
from
June 9, 2026 05:29
635b6bd to
a6b5c92
Compare
ethanndickson
force-pushed
the
ethan/agents-multi-terminal-tabs
branch
from
June 9, 2026 05:29
e7f2e8b to
3171944
Compare
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
from
June 9, 2026 06:55
a6b5c92 to
d70dd00
Compare
ethanndickson
marked this pull request as ready for review
June 9, 2026 06:56
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
from
June 9, 2026 12:55
d70dd00 to
679f311
Compare
ethanndickson
force-pushed
the
ethan/agents-multi-terminal-tabs
branch
from
June 9, 2026 12:55
3171944 to
912a4e1
Compare
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
from
June 9, 2026 13:06
679f311 to
09b7e94
Compare
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
3 times, most recently
from
June 10, 2026 06:44
6f1482d to
6e6d829
Compare
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
5 times, most recently
from
June 11, 2026 08:08
0db6498 to
51b7fad
Compare
ethanndickson
force-pushed
the
ethan/agents-app-frame-refactor
branch
from
June 11, 2026 13:34
51b7fad to
0887837
Compare
DanielleMaywood
approved these changes
Jun 11, 2026
DanielleMaywood
left a comment
DanielleMaywood
left a comment
Contributor
There was a problem hiding this comment.
Approving although we have two helpers that don't really make much sense to be exported from the file they're in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the workspace app iframe, wildcard warning, and workspace-app helper functions out of TaskPage into shared
site/src/modules/appsmodules. Existing agent and app lookups in the task chat helpers, download-logs dialog, and workspaces table now route through the sharedworkspaceAppshelpers instead of duplicating resource-flattening logic. The extracted frame preserves the existing preview-only toolbar behavior, and its open-in-new-tab link gainsrel="noreferrer"to harden against tabnabbing.Relates to CODAGT-346