fix!: mark ContainmentError as non_exhaustive - #2153
Merged
Conversation
EmptyPath and future public variants can land without forcing a major bump on every additive change. Downstream match arms should use a wildcard. Forces the next product release to 0.28.0 so cargo-semver-checks accepts EmptyPath vs published 0.27.0. Release-As: 0.28.0 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
SebTardif
pushed a commit
that referenced
this pull request
Aug 10, 2026
🤖 I have created a release *beep* *boop* --- ## [0.28.0](patchloom-v0.27.0...patchloom-v0.28.0) (2026-08-10) ### ⚠ BREAKING CHANGES * mark ContainmentError as non_exhaustive ([#2153](#2153)) ### Bug Fixes * empty path reject; honest winget docs ([#2150](#2150)) ([0f8c7e5](0f8c7e5)) * mark ContainmentError as non_exhaustive ([#2153](#2153)) ([220be47](220be47)) * MPI blank paths, release-please embed pins, dep bumps ([#2155](#2155)) ([9ecf62a](9ecf62a)) * PathGuard and MCP reject blank paths ([#2152](#2152)) ([624e612](624e612)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: patchloom-release[bot] <291219740+patchloom-release[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark public
ContainmentErroras#[non_exhaustive]so additive variants (includingEmptyPathfrom #2152) do not require a major bump every time.Release
Release-As: 0.28.0
This footer must stay in the squash commit body (release-please). After merge, release-please should replace the open 0.27.1 PR (#2151) with a 0.28.0 release PR so
cargo-semver-checksaccepts the API shape change vs published 0.27.0.Test plan
cargo test --lib --all-features containment::Notes
Do not merge release PR #2151 (0.27.1); it is the wrong version for this break.