Repository navigation
[web-animations-1] Add pseudoElement to getAnimations options - #11050
Conversation
|
|
||
| The returned list is sorted using | ||
| 1. If {{Animatable/getAnimations(options)/options}} is passed | ||
| with a non-null {{GetAnimationsOptions/pseudoElement}}, |
There was a problem hiding this comment.
We should probably have a similar SyntaxError exception thrown as we do for trying to create an animation effect targeting an invalid pseudo, e.g. see https://www.w3.org/TR/web-animations-1/#dom-keyframeeffect-pseudoelement
You can see this is also referenced by the KeyframeEffect constructor: https://www.w3.org/TR/web-animations-1/#ref-for-dom-keyframeeffect-pseudoelement, though in this case since we're not setting pseudoElement it probably can't point to the same reference.
There was a problem hiding this comment.
Done. I've tried to define the algorithm in the old spot and reference it, instead of copying the text. But let me know what you prefer. Also, do you think we need a separate resolution for the DOMException, since I don't believe getAnimations can throw prior to this change
There was a problem hiding this comment.
So looking at getComputedStyle which is very similar, it looks like MDN says it can throw on an invalid selector however I'm not sure where this is called out in the spec or how to trigger an exception in chrome, whereas for element.animate it is easy to trigger the exception with elem.animate({}, {pseudoElement: ':invalid-pseudo'});.
So we should probably get a consistent story for when we should throw on invalid pseudo selectors, but maybe this should be a separate issue explaining the current behavior of the APIs we have using pseudoElement selectors.
There was a problem hiding this comment.
I'd propose for now we land this with the exception for self consistency within the same spec, and follow up on this.
This corresponds to: w3c/csswg-drafts#11050 For now, we don't do anything with this parameter, because we don't yet support animating pseudo-elements.
This corresponds to: w3c/csswg-drafts#11050 For now, we don't do anything useful with this parameter, because we don't yet support animating pseudo-elements.
This corresponds to: w3c/csswg-drafts#11050 For now, we don't do anything useful with this parameter, because we don't yet support animating pseudo-elements.
This corresponds to: w3c/csswg-drafts#11050 For now, we don't do anything useful with this parameter, because we don't yet support animating pseudo-elements.
2 participants
[web-animations-1] Add pseudoElement to getAnimations options #9908