feat: add base template variables to API - #26425
Merged
Merged
Conversation
Docs preview📖 View docs preview for |
Contributor
Author
This was referenced Jun 16, 2026
jeremyruppel
marked this pull request as ready for review
June 16, 2026 17:50
jeremyruppel
changed the title
This was referenced Jun 16, 2026
jeremyruppel
force-pushed
the
jeremy/devex-283-fe-baseinfraselectstep
branch
from
June 16, 2026 20:42
68ca05a to
d046b0f
Compare
jeremyruppel
force-pushed
the
jeremy/devex-284-be-base-template-variables
branch
from
June 16, 2026 20:42
d34528f to
7fa30b7
Compare
zenithwolf1000
approved these changes
Jun 16, 2026
zenithwolf1000
left a comment
zenithwolf1000
left a comment
Contributor
There was a problem hiding this comment.
Minor idiomatic nit otherwise lgtm
Add support for base template variables in the template builder: - Add Variables field to BaseManifest, reusing ModuleVariable - Add variables to kubernetes base.json (use_kubeconfig, namespace) - Add Variables to codersdk.TemplateBuilderBase - Add BaseVariableValues to compose and create-template requests - Thread base variable values through the compose pipeline into BaseRenderContext - Add baseVariablesToSDK helper in handler to convert and filter computed variables - Restructure TestTemplateBuilderBases/OK as table-driven specs with per-base variable assertions - Regenerate TypeScript types and API docs
jeremyruppel
force-pushed
the
jeremy/devex-284-be-base-template-variables
branch
from
June 17, 2026 15:59
7fa30b7 to
c805e35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add backend support for base template variables in the template builder, enabling the frontend to render configuration forms for bases like Kubernetes that declare Terraform variables.
Variables []ModuleVariabletoBaseManifestandBaseVariables()accessoruse_kubeconfig,namespace)Variablesfield tocodersdk.TemplateBuilderBaseresponse typeBaseVariableValuestoTemplateBuilderComposeRequestandTemplateBuilderCreateTemplateRequestBaseRenderContextTestTemplateBuilderBases/OKas table-driven specs with per-base variable assertionsDocker and AWS bases have no user-configurable Terraform variables and remain empty.
Relates to DEVEX-284.
Note
This PR was authored with Coder Agents.